[MPlayer-cvslog] r21213 - in trunk/stream: stream_dvdnav.c stream_dvdnav.h

[Guillaume POIRIER]

On 11/25/06, Guillaume POIRIER <poirierg at gmail.com> wrote:
> Hi,
>
> <watchdog mode="on">
>
> On 11/25/06, nicodvb <subversion at mplayerhq.hu> wrote:
> > Author: nicodvb
> > Date: Sat Nov 25 13:17:34 2006
> > New Revision: 21213
> >
> > Modified:
> >    trunk/stream/stream_dvdnav.c
> >    trunk/stream/stream_dvdnav.h
> >
> > Log:
> > added code to identify subs language and count; needed for forthcoming support for -slang
> >
> > Modified: trunk/stream/stream_dvdnav.c
> > ==============================================================================
> > --- trunk/stream/stream_dvdnav.c        (original)
> > +++ trunk/stream/stream_dvdnav.c        Sat Nov 25 13:17:34 2006
> > @@ -476,6 +476,34 @@
> >    priv->mousey = y;
> >  }
> >
> > +int dvdnav_sid_from_lang(stream_t *stream, unsigned char *language) {
> > +  dvdnav_priv_t * priv=(dvdnav_priv_t*)stream->priv;
>
> Wouldn't it be nice to have doxygen comments here?
> Yes, what it does is pretty obvious... but it wouldn't hurt to say,
> know if *language is a 2 letter or 3 letter code, blah blah :-)

I didn't mean to be mean when I said this you know... it's just that
it's written in the code writing policy that new code should have doxy
comments


-- 
An association of men who will not quarrel with one another is a thing
which has never yet existed, from the greatest confederacy of nations
down to a town meeting or a vestry.
 -- Thomas Jefferson
(when interviewed about MPlayer ML flamewars)
http://www.brainyquote.com/quotes/quotes/t/thomasjeff157207.html