[MPlayer-cvslog] r21213 - in trunk/stream: stream_dvdnav.c stream_dvdnav.h

Nico Sabbi nsabbi at email.it
Fri Dec 1 15:19:12 CET 2006


Guillaume POIRIER wrote:

> On 11/25/06, Guillaume POIRIER <poirierg at gmail.com> wrote:
>
>> Hi,
>>
>> <watchdog mode="on">
>>
>> On 11/25/06, nicodvb <subversion at mplayerhq.hu> wrote:
>>
>> > +int dvdnav_sid_from_lang(stream_t *stream, unsigned char *language) {
>> > +  dvdnav_priv_t * priv=(dvdnav_priv_t*)stream->priv;
>>
>> Wouldn't it be nice to have doxygen comments here?
>> Yes, what it does is pretty obvious... but it wouldn't hurt to say,
>> know if *language is a 2 letter or 3 letter code, blah blah :-)
>
>
> I didn't mean to be mean when I said this you know... it's just that
> it's written in the code writing policy that new code should have doxy
> comments
>
>
oh, but you are _always_ so mean, Mr watchdog! ;)
I simply forgot it. Tonight I'll comply with my duties



More information about the MPlayer-cvslog mailing list