[MPlayer-cvslog] CVS: main/libfaad2 ps_dec.c,1.3,1.4

Dominik Mierzejewski CVS syncmail at mplayerhq.hu
Thu Feb 9 15:08:27 CET 2006

CVS change done by Dominik Mierzejewski CVS

Update of /cvsroot/mplayer/main/libfaad2
In directory mail:/var2/tmp/cvs-serv31671/libfaad2

Modified Files:
Log Message:
Patch by Stefan Huehner / stefan % huehner ! org \

patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.

Comments about a similar patch applied to ffmpeg:

That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård

Index: ps_dec.c
RCS file: /cvsroot/mplayer/main/libfaad2/ps_dec.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ps_dec.c	5 Dec 2005 01:31:53 -0000	1.3
+++ ps_dec.c	9 Feb 2006 14:07:54 -0000	1.4
@@ -159,7 +159,7 @@
 /* static function declarations */
 static void ps_data_decode(ps_info *ps);
-static hyb_info *hybrid_init();
+static hyb_info *hybrid_init(void);
 static void channel_filter2(hyb_info *hyb, uint8_t frame_len, const real_t *filter,
                             qmf_t *buffer, qmf_t **X_hybrid);
 static void INLINE DCT3_4_unscaled(real_t *y, real_t *x);
@@ -189,7 +189,7 @@
 /*  */
-static hyb_info *hybrid_init()
+static hyb_info *hybrid_init(void)
     uint8_t i;

More information about the MPlayer-cvslog mailing list