[MPlayer-cvslog] CVS: main/libmpcodecs/native xa_gsm.c, 1.5, 1.6 xa_gsm.h,, 1.2

Dominik Mierzejewski CVS syncmail at mplayerhq.hu
Thu Feb 9 15:08:29 CET 2006

CVS change done by Dominik Mierzejewski CVS

Update of /cvsroot/mplayer/main/libmpcodecs/native
In directory mail:/var2/tmp/cvs-serv31671/libmpcodecs/native

Modified Files:
	xa_gsm.c xa_gsm.h 
Log Message:
Patch by Stefan Huehner / stefan % huehner ! org \

patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.

Comments about a similar patch applied to ffmpeg:

That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård

Index: xa_gsm.c
RCS file: /cvsroot/mplayer/main/libmpcodecs/native/xa_gsm.c,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- xa_gsm.c	27 Aug 2002 16:17:54 -0000	1.5
+++ xa_gsm.c	9 Feb 2006 14:07:56 -0000	1.6
@@ -40,7 +40,7 @@
 static XA_GSM_STATE gsm_state;
-void GSM_Init()
+void GSM_Init(void)
   memset((char *)(&gsm_state), 0, sizeof(XA_GSM_STATE));
   gsm_state.nrp = 40;

Index: xa_gsm.h
RCS file: /cvsroot/mplayer/main/libmpcodecs/native/xa_gsm.h,v
retrieving revision
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- xa_gsm.h	24 Feb 2001 20:31:26 -0000
+++ xa_gsm.h	9 Feb 2006 14:07:56 -0000	1.2
@@ -1,6 +1,6 @@
 void XA_MSGSM_Decoder(unsigned char *ibuf,unsigned short *obuf);
 void XA_GSM_Decoder(unsigned char *ibuf,unsigned short *obuf);
-void GSM_Init();
+void GSM_Init(void);

More information about the MPlayer-cvslog mailing list