[MPlayer-cvslog] r19188 - trunk/mplayer.c

[Uoti Urpala]

On Wed, 2006-07-26 at 20:52 +0200, reimar wrote:
> demuxer might not set i_bps, so do not divide by it in that case

Most decoders also set it. Did you encounter a divide by zero with some
combination? The comments above mention a case where this code might
possibly be called even if the decoder uses the new way of tracking pts,
but if i_bps is unset and the decoder uses the old way then I'd expect
audio sync to be off by the amount of audio in one demuxer packet.

> +	if (sh_audio->i_bps)
>  	a_pts += (ds_tell_pts(d_audio) - sh_audio->a_in_buffer_len) /
>  	    (double)sh_audio->i_bps;

Fix the indentation after changes like this. Do another commit if you
insist on separating cosmetic changes (though for a minimal block like
this it's IMO more work for both the committer and possible reviewers to
go through 2 commits), but at least do it somehow instead of letting the
sources rot.