[MPlayer-cvslog] r19188 - trunk/mplayer.c

[Reimar Döffinger]

Hello,
On Wed, Jul 26, 2006 at 10:39:46PM +0300, Uoti Urpala wrote:
> Most decoders also set it. Did you encounter a divide by zero with some
> combination?

No, it won't since those are floats. Instead the current time is
displayed as "inf".

> > +	if (sh_audio->i_bps)
> >  	a_pts += (ds_tell_pts(d_audio) - sh_audio->a_in_buffer_len) /
> >  	    (double)sh_audio->i_bps;
> 
> Fix the indentation after changes like this. Do another commit if you
> insist on separating cosmetic changes (though for a minimal block like
> this it's IMO more work for both the committer and possible reviewers to
> go through 2 commits), but at least do it somehow instead of letting the
> sources rot.

Well, for me it makes not a big change in readability, so I didn't
bother. And since the indentation is a mixture of tabs and spaces (first
level is 4 spaces, second is one tab), I don't really know how I am
supposed to fix it.
Though I can send patches for such stuff (at least when it concerns your
code) and you can fix it all in the way you like it :-).
And no, I also don't really think that it needs to be split in a
cosmetics-only patch for such a case.

Greetings,
Reimar Döffinger