[MPlayer-cvslog] CVS: main subreader.c,1.147,1.148

[Alban Bedel]

On Sat, 18 Mar 2006 18:13:09 +0100
Jindrich Makovicka <makovick at kmlinux.fjfi.cvut.cz> wrote:

> Alban Bedel wrote:
> > On Sat, 18 Mar 2006 17:09:58 +0100
> > Jindrich Makovicka <makovick at kmlinux.fjfi.cvut.cz> wrote:
> >>> 3. decrease enca buffer
> >> Sounds reasonable - I am going to change guess_cp to decrease the buffer 
> >> for unseekable streams instead.
> > 
> > I'll second that 256KB seems quiet a lot anyway (many sub files are not
> > that big). On the other hand we could still run in situations where a single
> > stream buffer is not enouth anyway.
> 
> As I don't completely understand the whole stream mess, here is the 
> intended fix. It works for me on unseekable http. Is it ok to commit?

You should have used cache_stream_fill_buffer() but otherwise that look ok.
However i would prefer going the "unput" route as it would be more reliable
and could be useful with some other stuff. I'll do a patch for that.

	Albeu