[MPlayer-cvslog] CVS: main subreader.c,1.147,1.148

Ivan Kalvachev ikalvachev at gmail.com
Sun Mar 19 12:24:48 CET 2006

2006/3/18, Jindrich Makovicka <makovick at kmlinux.fjfi.cvut.cz>:
> Alban Bedel wrote:
> > On Sat, 18 Mar 2006 17:09:58 +0100
> > Jindrich Makovicka <makovick at kmlinux.fjfi.cvut.cz> wrote:
> >>> 3. decrease enca buffer
> >> Sounds reasonable - I am going to change guess_cp to decrease the buffer
> >> for unseekable streams instead.
> >
> > I'll second that 256KB seems quiet a lot anyway (many sub files are not
> > that big). On the other hand we could still run in situations where a single
> > stream buffer is not enouth anyway.
> As I don't completely understand the whole stream mess, here is the
> intended fix. It works for me on unseekable http. Is it ok to commit?

I'm not sure what will malloc(0)  won't return NULL pointer.
I think it is better to just 'return;' from the funtion.

I still would like a little bit bigger buffer (st->block_size). 64kb
might be enough.

However Albeu, you must have noticed that we have to workaround
(cache_)stream_fill_buffer() here too, or it may not fill the whole
buffer (worst case 1 byte).
I would hope that now you will agree that stream_fill_buffer() must
fill the buffer.

More information about the MPlayer-cvslog mailing list