[MPlayer-cvslog] CVS: main/libvo vo_s3fb.c, NONE, 1.1 video_out.c, 1.107, 1.108

[Ivo]

Hi,

A few things I noticed after I cvs-upped:

On Wednesday 17 May 2006 22:56, Guillaume Poirier CVS wrote:
> #include <sys/mman.h>

There's HAVE_SYS_MMAN_H (un)defined in config.h.

> #include "config.h"

... this one probably has to move up.

>   if (iopl(3) != 0)

iopl() needs sys/io.h

>     printf("s3fb: can't open %s: %s\n", name, strerror(errno));

The code is full of printf's. Should be mp_msg and preferably translatable 
strings.

Nothing major, and I don't have the hardware to test if it actually works :)

--Ivo