[MPlayer-cvslog] CVS: main/libvo vo_s3fb.c, NONE, 1.1 video_out.c, 1.107, 1.108

[Guillaume POIRIER]

Hi,

On 5/17/06, Ivo <ivop at euronet.nl> wrote:
> Hi,
>
> A few things I noticed after I cvs-upped:
>
> On Wednesday 17 May 2006 22:56, Guillaume Poirier CVS wrote:
> > #include <sys/mman.h>
>
> There's HAVE_SYS_MMAN_H (un)defined in config.h.
>
> > #include "config.h"
>
> ... this one probably has to move up.
>
> >   if (iopl(3) != 0)
>
> iopl() needs sys/io.h
>
> >     printf("s3fb: can't open %s: %s\n", name, strerror(errno));
>
> The code is full of printf's. Should be mp_msg and preferably translatable
> strings.
>
> Nothing major, and I don't have the hardware to test if it actually works :)

Neither do I. Please modify and commit your changes yourself (except
maybe printfs). It's be much less error-prone than if I do it myself.

If you see more problems, don't hesitate to go ahead and commit your changes.

This code has been sitting on mplayer-dev with no review whatsoever,
so I'm not surprised that it doesn't meet our coding standards.

Guilllaume
-- 
An Israeli man's life was saved when he was given a Palestinian man's
heart in a heart transplant operation. The guy is doing fine, but the
bad news is, he can't stop throwing rocks at himself.
  -- Jay Leno