[MPlayer-cvslog] r25306 - trunk/libmpcodecs/ad_libdca.c

[Michael Niedermayer]

On Thu, Dec 06, 2007 at 03:17:52AM +0200, Ivan Kalvachev wrote:
> On Dec 6, 2007 2:08 AM, Ulion <ulion2002 at gmail.com> wrote:
> > 2007/12/6, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org>:
> > > On Wednesday, 05 December 2007 at 19:24, ulion wrote:
> > > > Author: ulion
> > > > Date: Wed Dec  5 19:24:40 2007
> > > > New Revision: 25306
> > > >
> > > > Log:
> > > > Prevent from outputing mass of 'skip' log messages in verbose level.
> > >
> > > Why not set the loglevel to something higher instead? MSGL_DBG2, for example.
> >
> > Sorry, in the dev list, Diego suggest me to comment out that line.
> 
> He said set to MSGL_DBG2 _or_ comment out.

and he did so why do you complain, or do you mean ulion should have
changed it to MSGL_DBG2 AND commented it out ;)

either way i also think the skip message when the sync code doesnt immedeatly
find a sync word but skips ahead is usefull and shouldnt be commented out

diego loves cleanng stuff up and i think he sometimes overdoes it :)

now i never worked on the libdca code and likely never will so my oppinion
isnt too relevant
its roberto who should decide if "skip" should be commented out be MSGL_DBG2
or MSGL_V


[...]
> Also,
> Have in mind that there are code crawlers that tag a file and clean it up
> >from commented and disabled code. If you comment something out
> after some time they will delete is as "cruft".
> These crawlers never debug code.

resistance is futile, you will be cleaned up :)
and this reminds me i need to resurrect a few functions in snow.c ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20071206/9d0bf920/attachment.pgp>