[MPlayer-cvslog] r25306 - trunk/libmpcodecs/ad_libdca.c

[The Wanderer]

Ivan Kalvachev wrote:

> On Dec 6, 2007 2:08 AM, Ulion <ulion2002 at gmail.com> wrote:
> 
>> 2007/12/6, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org>:
>> 
>>> Why not set the loglevel to something higher instead? MSGL_DBG2,
>>> for example.
>> 
>> Sorry, in the dev list, Diego suggest me to comment out that line.
> 
> He said set to MSGL_DBG2 _or_ comment out.
> 
>> According an old post discuss between comment out and set a debug
>> level, I remember someone said comment out the debug line maybe
>> more useful than set it to debug level since when debug output is
>> opened, too many output messages is there we normally not use debug
>> level for real debug. While when we really need to debug, we
>> normally set the debug line be verbose. Then for a comment out
>> line, we need two backspace key to restore the verbose output,
>> while for debug level line, we need more keys to change its debug
>> level to verbose.
> 
> Doesn't make sense to me. It definitely takes more typing to start
> text editor, find the correct line(s), edit, save, recompile, and
> then debug, than just debug by "-v -v".

I think he meant that it takes more typing to remove the comment marker
than to change the message from DBG2 back to something which will be
printed with just one '-v'.

This is certainly true, but why it would be necessary to do so is not
something entirely clear.

> In case you need some user to supply the verbose log, it would be
> major pain to explain what he has to do in order to enable the output
> code.

This is certainly true as well.

> Also, Have in mind that there are code crawlers that tag a file and
> clean it up from commented and disabled code. If you comment
> something out after some time they will delete is as "cruft".

Are any of these crawlers (which I infer are automated programs, not
actual users) being run on the MPlayer source tree?

Even if so, how would their work wind up being committed to the
repository without the mistake being caught?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.