[MPlayer-cvslog] r23727 - trunk/libdvdcss/libdvdcss.c

[Reimar Döffinger]

Hello,
On Sat, Jul 14, 2007 at 02:50:00PM +0200, Diego Biurrun wrote:
> On Sat, Jul 14, 2007 at 10:06:31AM +0200, Reimar Döffinger wrote:
> > It is not a very relevant change though (esp. compared to  r23728).
> > You could also cast all parameters to unsigned instead.
> > IMO using sprintf (and even snprintf) here is a stupid idea anyway.
> 
> I'm asking because I wish to keep our diffs to upstream as small as
> possible.  If r23728 is enough to solve the problem then this might as
> well be reverted.

It solves the critical problem, but without it the format strings do not
match the type, though I do not know on what type of system it will make
a difference.

Greetings,
Reimar Döffinger