[MPlayer-cvslog] r23727 - trunk/libdvdcss/libdvdcss.c

Diego Biurrun diego at biurrun.de
Mon Jul 16 23:24:17 CEST 2007

On Sat, Jul 14, 2007 at 03:23:46PM +0200, Reimar Döffinger wrote:
> On Sat, Jul 14, 2007 at 02:50:00PM +0200, Diego Biurrun wrote:
> > On Sat, Jul 14, 2007 at 10:06:31AM +0200, Reimar Döffinger wrote:
> > > It is not a very relevant change though (esp. compared to  r23728).
> > > You could also cast all parameters to unsigned instead.
> > > IMO using sprintf (and even snprintf) here is a stupid idea anyway.
> > 
> > I'm asking because I wish to keep our diffs to upstream as small as
> > possible.  If r23728 is enough to solve the problem then this might as
> > well be reverted.
> It solves the critical problem, but without it the format strings do not
> match the type, though I do not know on what type of system it will make
> a difference.

Umm, you mean Ivan's commit solves the critical problem while yours makes
the types match?

My point is that if your commit is more or less cosmetic then I would
suggest reverting it to minimize the diff towards upstream.


More information about the MPlayer-cvslog mailing list