[MPlayer-cvslog] r24941 - trunk/mplayer.c

[Uoti Urpala]

On Tue, 2007-11-13 at 17:55 +0100, Dominik 'Rathann' Mierzejewski wrote:
> And you seem to be the only one with that opinion. While I respect your
> right to have a different opinion, I'm quite convinced that you should
> respect the opinion of other developers and do things the way we ask you
> to do them.

I'm quite sure that not everyone else considers splitting every
indentation change the way you want to be useful or even at all
sensible. What exactly everyone considers worth splitting most likely
varies but you are at an extreme.

> > > > Having twice as many commits in the revision history is a significant
> > > > drawback too.
> > > 
> > > How so? Besides, not every code change involves reindentation or other
> > > cosmetic changes. In fact, only a small minority of them do.
> > > Don't exaggerate it.
> > 
> > If you say that only a small minority of commits are affected it is an
> > argument for splitting/not splitting not mattering much either way. It
> > does not affect the relative merits of the alternatives; any benefit
> > from splitting would only affect the same "small minority" too.
> 
> You're saying you will ignore the rule, because it happens only in a few
> cases. I'm saying it shouldn't be a big burden on you to follow the rule

No, you are the one that brought up the "small minority" thing and what
I'm saying is that your argument makes no sense.

> exactly because it concerns only a few cases. Now which one of us is being
> unreasonable? You're thinking about your own convenience. I'm thinking
> about the convenience of anyone who looks at the commits.

You are not on the side of "everyone".

>  Are you saying
> other people should adapt to your ways? Shouldn't it be the other way
> around?

Maybe you should ask yourself that question. You do very little C
development and I do not remember you spotting a real bug in C code on
-cvslog either. Yet you are one of the people most likely to flame those
that do something, and usually over the most trivial stylistic things or
over not mechanically following some rules. Is it that you don't
understand the important things and so concentrate on the trivialities
that are within your grasp?