[MPlayer-cvslog] r24941 - trunk/mplayer.c

[Dominik 'Rathann' Mierzejewski]

On Tuesday, 13 November 2007 at 19:11, Uoti Urpala wrote:
> On Tue, 2007-11-13 at 17:55 +0100, Dominik 'Rathann' Mierzejewski wrote:
> > And you seem to be the only one with that opinion. While I respect your
> > right to have a different opinion, I'm quite convinced that you should
> > respect the opinion of other developers and do things the way we ask you
> > to do them.
> 
> I'm quite sure that not everyone else considers splitting every
> indentation change the way you want to be useful or even at all
> sensible. What exactly everyone considers worth splitting most likely
> varies but you are at an extreme.

I don't think so. It's pretty simple, really. Either you split the cosmetic
changes or you don't. There is no in-between.

[...]
> > You're saying you will ignore the rule, because it happens only in a few
> > cases. I'm saying it shouldn't be a big burden on you to follow the rule
> 
> No, you are the one that brought up the "small minority" thing and what
> I'm saying is that your argument makes no sense.

That it doesn't make sense to you doesn't mean it doesn't make sense at all.
I was just trying to explain it in a reasonable way.

> > exactly because it concerns only a few cases. Now which one of us is being
> > unreasonable? You're thinking about your own convenience. I'm thinking
> > about the convenience of anyone who looks at the commits.
> 
> You are not on the side of "everyone".

I never said I was. But I don't see a crowd of supporters around you, while
I see several developers expressing views similar to mine.

> >  Are you saying
> > other people should adapt to your ways? Shouldn't it be the other way
> > around?
> 
> Maybe you should ask yourself that question. You do very little C
> development and I do not remember you spotting a real bug in C code on
> -cvslog either.

I could find a couple from the times you weren't here but frankly I don't
feel I have to prove anything to you.

> Yet you are one of the people most likely to flame

You haven't seen me flame yet.

> those that do something,

You're implying I don't do anything, which is simply false. But please, keep
believing that for all I care.

> and usually over the most trivial stylistic things or
> over not mechanically following some rules.

All these rules have been created for a reason. That you don't agree with
them doesn't give you a right to ignore them whenever you feel like it. I
said it before, but you seem to have forgotten. If you don't like the
rules, start a discussion about how they could be changed. Ignoring them
before that discussion has even started is, at the very least, impolite.

> Is it that you don't understand the important things and so concentrate
> on the trivialities that are within your grasp?

If vague personal attacks make you feel better, please continue. I don't mind.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan