[MPlayer-cvslog] r27550 - in trunk: libmpdemux/demux_mkv.c mpcommon.c

Tue Sep 9 23:23:32 CEST 2008

On Tuesday, 09 September 2008 at 23:16, Diego Biurrun wrote:
> On Tue, Sep 09, 2008 at 09:11:41AM +0200, Reimar Döffinger wrote:
> > On Mon, Sep 08, 2008 at 11:26:22PM +0200, uau wrote:
> > > 
> > > Log:
> > > Revert bad changes to SSA/ASS subtitle packet format
> > > [...]
> > 
> > That is not an acceptable commit message. If it needs such a long
> > explanation, explain it on the mailing list and reference the mail, but
> > commit messages are supposed to be messages, not whole reference books.
> 
> I disagree.  It's better to have it in the log message than on the ml.

I agree with Reimar. Such long commit messages take a while to read.
IMHO the point of a commit message is to describe the changes concisely
in a couple of sentences so that one can look at "svn log" output without
needing the diffs.

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | Livna http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan