[MPlayer-cvslog] r27550 - in trunk: libmpdemux/demux_mkv.c mpcommon.c

[Diego Biurrun]

On Tue, Sep 09, 2008 at 11:23:32PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> On Tuesday, 09 September 2008 at 23:16, Diego Biurrun wrote:
> > On Tue, Sep 09, 2008 at 09:11:41AM +0200, Reimar Döffinger wrote:
> > > On Mon, Sep 08, 2008 at 11:26:22PM +0200, uau wrote:
> > > > 
> > > > Log:
> > > > Revert bad changes to SSA/ASS subtitle packet format
> > > > [...]
> > > 
> > > That is not an acceptable commit message. If it needs such a long
> > > explanation, explain it on the mailing list and reference the mail, but
> > > commit messages are supposed to be messages, not whole reference books.
> > 
> > I disagree.  It's better to have it in the log message than on the ml.
> 
> I agree with Reimar. Such long commit messages take a while to read.
> IMHO the point of a commit message is to describe the changes concisely
> in a couple of sentences so that one can look at "svn log" output without
> needing the diffs.

No.  The diffs can never explain why the change they describe was made,
they only show you what the change consists of.  Very often, it is not
at all easy to deduce one from the other.  This is an example of such a
case.

Diego