[MPlayer-cvslog] r28760 - trunk/libvo/vo_vdpau.c

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Feb 28 16:46:58 CET 2009


Reimar Döffinger <Reimar.Doeffinger <at> stud.uni-karlsruhe.de> writes:

> 
> On Sat, Feb 28, 2009 at 02:20:02PM +0100, cehoyos wrote:
> > +    VdpVideoMixerAttribute attributes[] =
{VDP_VIDEO_MIXER_ATTRIBUTE_CSC_MATRIX};
> 
> Maybe static const?

Fixed.

> > +        procamp.hue = value / 100.0 * 3.141592;
> 
> This (and the other place where it appears) should be M_PI - this is not
> part of C99 I think, but already required by FFmpeg, you can use
> libavutil/mathematics.h to get it defined in a portable way.

I originally had the same idea, but thought that PI isn't changing that fast
anyway.

Also fixed, Carl Eugen




More information about the MPlayer-cvslog mailing list