[MPlayer-cvslog] r28760 - trunk/libvo/vo_vdpau.c

[Reimar Döffinger]

On Sat, Feb 28, 2009 at 03:46:58PM +0000, Carl Eugen Hoyos wrote:
> Reimar Döffinger <Reimar.Doeffinger <at> stud.uni-karlsruhe.de> writes:
> > > +        procamp.hue = value / 100.0 * 3.141592;
> > 
> > This (and the other place where it appears) should be M_PI - this is not
> > part of C99 I think, but already required by FFmpeg, you can use
> > libavutil/mathematics.h to get it defined in a portable way.
> 
> I originally had the same idea, but thought that PI isn't changing that fast
> anyway.

No, it's just a matter of readability and also precision (the constant
above is far from double precision, M_PI is defined far more precisely).
Obviously none of these were particularly relevant issues.