[MPlayer-cvslog] r32009 - in trunk: eosd.c eosd.h

[Reimar Döffinger]

Please just go ahead and apply something.
And you're not the first to break --disable-ass, so don't worry
too much about that.

On Wed, Aug 25, 2010 at 03:00:59PM +0200, Nicolas George wrote:
> @@ -35,6 +36,7 @@ void eosd_ass_init(ASS_Library *ass_library)
>      if (!ass_renderer) return;
>      ass_configure_fonts(ass_renderer);
>  }
> +#endif

If it might simplify some code it's also okay to only #if away the
function body.
Also I think CONFIG_ASS is either defined to 1 or undefined, not
1 or 0, in that case #ifdef would be more correct.
Though in the long term I am in favour of moving to 0/1 instead of
1/undef for all defines.

> +#if CONFIG_ASS
>      if (sub_visibility && ass_renderer && ass_track && ts != MP_NOPTS_VALUE) {
>          r = ass_mp_render_frame(ass_renderer, ass_track, (ts+sub_delay) * 1000 + .5, changed);
>          if (!prev_visibility && changed)
>              *changed = 2;
>      }
>      prev_visibility = sub_visibility;
> +#endif

Either sub_visibility is not specific to ASS, then I'd suggest moving it
outside the #if, or it is then its name should reflect that.