[MPlayer-cvslog] r32009 - in trunk: eosd.c eosd.h

Nicolas George nicolas.george at normalesup.org
Wed Aug 25 19:43:18 CEST 2010

L'octidi 8 fructidor, an CCXVIII, Reimar Döffinger a écrit :
> Please just go ahead and apply something.
> And you're not the first to break --disable-ass, so don't worry
> too much about that.


> If it might simplify some code it's also okay to only #if away the
> function body.

It amounts to roughly the same: the calls are already #ifed.

> Also I think CONFIG_ASS is either defined to 1 or undefined, not
> 1 or 0, in that case #ifdef would be more correct.

The rest of the code uses #ifdef, I adapted.

> > +#if CONFIG_ASS
> >      if (sub_visibility && ass_renderer && ass_track && ts != MP_NOPTS_VALUE) {
> >          r = ass_mp_render_frame(ass_renderer, ass_track, (ts+sub_delay) * 1000 + .5, changed);
> >          if (!prev_visibility && changed)
> >              *changed = 2;
> >      }
> >      prev_visibility = sub_visibility;
> > +#endif
> Either sub_visibility is not specific to ASS, then I'd suggest moving it
> outside the #if, or it is then its name should reflect that.

sub_visibility is the global variable changed by the 'v' command.

On the other hand, the test and edge-detection is ASS-specific, and is moved
as a block in the eosd-dynamic version of these functions.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-eosd-00-noass-20100825-1925.diff
Type: text/x-diff
Size: 1959 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20100825/21594165/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20100825/21594165/attachment-0001.pgp>

More information about the MPlayer-cvslog mailing list