[MPlayer-cvslog] r31531 - trunk/libmpdemux/demux_real.c

Attila Kinali attila at kinali.ch
Wed Jun 23 13:35:37 CEST 2010

On Wed, 23 Jun 2010 12:59:26 +0200 (CEST)
diego <subversion at mplayerhq.hu> wrote:

> Author: diego
> Date: Wed Jun 23 12:59:26 2010
> New Revision: 31531
> Log:
> Remove duplicated MKTAG macro definition, #include libavutil/common.h instead.

This is IMHO a bad idea. To safe very little, well confined code
dublication, you just added a dependency to libavutil.
While this is already by itself a bad idea, you also forgot to
change configure to disable the real demuxer when libavutil is not
available, which is clearly a compile time bug.

IMHO you should revert this change.

			Attila Kinali

If you want to walk fast, walk alone.
If you want to walk far, walk together.
		-- African proverb

More information about the MPlayer-cvslog mailing list