[MPlayer-cvslog] r31531 - trunk/libmpdemux/demux_real.c

[Diego Biurrun]

On Wed, Jun 23, 2010 at 01:35:37PM +0200, Attila Kinali wrote:
> On Wed, 23 Jun 2010 12:59:26 +0200 (CEST)
> diego <subversion at mplayerhq.hu> wrote:
> > 
> > Log:
> > Remove duplicated MKTAG macro definition, #include libavutil/common.h instead.
> 
> This is IMHO a bad idea. To safe very little, well confined code
> dublication, you just added a dependency to libavutil.
> While this is already by itself a bad idea, you also forgot to
> change configure to disable the real demuxer when libavutil is not
> available, which is clearly a compile time bug.
> 
> IMHO you should revert this change.

libavutil is a compile-time dependency of MPlayer already.

Diego