[MPlayer-cvslog] r32777 - in trunk: DOCS/man/en/mplayer.1 help/help_mp-cs.h help/help_mp-de.h help/help_mp-en.h help/help_mp-es.h help/help_mp-fr.h help/help_mp-hu.h help/help_mp-it.h help/help_mp-pl.h help/help_mp...

[Clément Bœsch]

On Mon, Jan 10, 2011 at 08:29:51PM +0100, Reimar Döffinger wrote:
> On Mon, Jan 10, 2011 at 08:18:52PM +0100, cboesch wrote:
> > +     end_at.type == END_AT_SIZE && end_at.pos < stream_tell(mpctx->stream))
> 
> I just realized one thing: I think this might not behave quite as expected
> when used with -sb
> Well, or rather I can't decide which would be the expected behaviour.
> Maybe you could test it (for both if conditions) and document it?

What do you want to say more than "Stop at given time or byte position."?

Also, I'm not able to get -sb working correctly :p

Btw, -sb seems to be used only to jump a few bytes (no MB for example) so
not sure this is really relevant.

And finally, -endpos with byte position "may not be accurate" from manpage
so…

I'm sure we can improve it, but I just ported it from mencoder, so well,
it should work just as it is in this one.

If you think it's not the correct way to do it, I can revert it.

-- 
Clément B.