[MPlayer-cvslog] r32777 - in trunk: DOCS/man/en/mplayer.1 help/help_mp-cs.h help/help_mp-de.h help/help_mp-en.h help/help_mp-es.h help/help_mp-fr.h help/help_mp-hu.h help/help_mp-it.h help/help_mp-pl.h help/help_mp...

[Reimar Döffinger]

On Wed, Jan 12, 2011 at 10:08:12PM +0100, Clément Bœsch wrote:
> On Mon, Jan 10, 2011 at 08:29:51PM +0100, Reimar Döffinger wrote:
> > On Mon, Jan 10, 2011 at 08:18:52PM +0100, cboesch wrote:
> > > +     end_at.type == END_AT_SIZE && end_at.pos < stream_tell(mpctx->stream))
> > 
> > I just realized one thing: I think this might not behave quite as expected
> > when used with -sb
> > Well, or rather I can't decide which would be the expected behaviour.
> > Maybe you could test it (for both if conditions) and document it?
> 
> What do you want to say more than "Stop at given time or byte position."?

The only question is "relative to the start of the file or relative to
the playback start (as given with -sb or -ss respectively)"?

> Also, I'm not able to get -sb working correctly :p

I think it only works with (some?) MPEG formats.

> Btw, -sb seems to be used only to jump a few bytes (no MB for example) so
> not sure this is really relevant.

Huh? It should be possible to use -sb to skip e.g. the first GB.

> And finally, -endpos with byte position "may not be accurate" from manpage
> so…

Well, being off a full GB is more than just "not accurate".

> I'm sure we can improve it, but I just ported it from mencoder, so well,
> it should work just as it is in this one.

Huh? Should be the same for mencoder and MPlayer itself.