[MPlayer-cvslog] r36009 - trunk/configure

Ivan Kalvachev ikalvachev at gmail.com
Tue Mar 19 21:15:50 CET 2013


On 3/19/13, diego <subversion at mplayerhq.hu> wrote:
> Author: diego
> Date: Tue Mar 19 11:42:28 2013
> New Revision: 36009
>
> Log:
> configure: Set CPPFLAGS to enable commonly used system features
>
> MPlayer relies on POSIX, XOPEN and C99 features being available. However,
> the necessary CPPFLAGS to enable those features are not set explicitly;
> they are just used in some configure tests.  Set flags for these features
> explicitly in order to ensure they are always available.
>
> Modified:
>    trunk/configure
>
> Modified: trunk/configure
> ==============================================================================
> --- trunk/configure	Tue Mar 19 11:42:26 2013	(r36008)
> +++ trunk/configure	Tue Mar 19 11:42:28 2013	(r36009)
> @@ -2721,6 +2721,8 @@ else
>    warn_cflags=yes
>  fi
>
> +CFLAGS="-D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
> $CFLAGS"
> +
>  if test "$cc_vendor" = "gnu" ; then
>    cflag_check -fno-tree-vectorize && CFLAGS="$CFLAGS -fno-tree-vectorize"
>    cflag_check -Wundef && WARNFLAGS="-Wundef $WARNFLAGS"
> @@ -2730,8 +2732,6 @@ if test "$cc_vendor" = "gnu" ; then
>    cflag_check -Wdisabled-optimization &&
> WARN_CFLAGS="-Wdisabled-optimization $WARN_CFLAGS"
>    cflag_check -Wmissing-prototypes && WARN_CFLAGS="-Wmissing-prototypes
> $WARN_CFLAGS"
>    cflag_check -Wstrict-prototypes && WARN_CFLAGS="-Wstrict-prototypes
> $WARN_CFLAGS"
> -else
> -  CFLAGS="-D_ISOC99_SOURCE $CFLAGS"
>  fi
>
>  cflag_check -mno-omit-leaf-frame-pointer &&
> cflags_no_omit_leaf_frame_pointer="-mno-omit-leaf-frame-pointer"

So this breaks FreeBSD build.

Your proposed fix http://paste.debian.net/hidden/34fe9dfb/ looks just
like an uglier hack that partially reverts this commit.


More information about the MPlayer-cvslog mailing list