[MPlayer-cvslog] r36009 - trunk/configure

Diego Biurrun diego at biurrun.de
Tue Mar 19 23:44:02 CET 2013


On Tue, Mar 19, 2013 at 10:15:50PM +0200, Ivan Kalvachev wrote:
> On 3/19/13, diego <subversion at mplayerhq.hu> wrote:
> >
> > Log:
> > configure: Set CPPFLAGS to enable commonly used system features
> >
> > --- trunk/configure	Tue Mar 19 11:42:26 2013	(r36008)
> > +++ trunk/configure	Tue Mar 19 11:42:28 2013	(r36009)
> > @@ -2721,6 +2721,8 @@ else
> >
> > +CFLAGS="-D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600
> > $CFLAGS"
> > +
> >  if test "$cc_vendor" = "gnu" ; then
> >    cflag_check -fno-tree-vectorize && CFLAGS="$CFLAGS -fno-tree-vectorize"
> > @@ -2730,8 +2732,6 @@ if test "$cc_vendor" = "gnu" ; then
> >    cflag_check -Wstrict-prototypes && WARN_CFLAGS="-Wstrict-prototypes
> > $WARN_CFLAGS"
> > -else
> > -  CFLAGS="-D_ISOC99_SOURCE $CFLAGS"
> >  fi
> >
> >  cflag_check -mno-omit-leaf-frame-pointer &&
> > cflags_no_omit_leaf_frame_pointer="-mno-omit-leaf-frame-pointer"
> 
> So this breaks FreeBSD build.
> 
> Your proposed fix http://paste.debian.net/hidden/34fe9dfb/ looks just
> like an uglier hack that partially reverts this commit.

That patch enables -D_POSIX_C_SOURCE=200112 and -D_XOPEN_SOURCE=600
only for glibc, which is the correct solution.

Diego


More information about the MPlayer-cvslog mailing list