[MPlayer-dev-eng] [PATCH] Warning fixes
seru
seru at gmx.net
Sat Dec 21 18:53:31 CET 2002
El sáb, 21 de dic de 2002, a las 06:48:08 +0100, Dominik Mierzejewski dijo:
> On Saturday, 21 December 2002, seru wrote:
> [...]
> > /* Fix 4 */
> > ../loader/qtx/qtxsdk/components.h:157:56: warning: multi-character character constant
> > ../loader/qtx/qtxsdk/components.h:158:56: warning: multi-character character constant
> > ../loader/qtx/qtxsdk/components.h:159:56: warning: multi-character character constant
> > ../loader/qtx/qtxsdk/components.h:160:56: warning: multi-character character constant
> > ../loader/qtx/qtxsdk/components.h:161:56: warning: multi-character character constant
> > ../loader/qtx/qtxsdk/components.h:162:56: warning: multi-character character constant
> > [...]
> >
> > Fix attached (fire-warningfix4.patch)
> > I copy/pasted the way it is done in loader/dshow/libwin32.h
>
> Have you tested it? I tried the same "fix" once and it caused SIGSEGV in qt
> loader.
Nope, but the warning disappeared. Don't commit that fix :)
#define FOUR_CHAR_CODE(x) ((unsigned long)(x)) /* otherwise compiler will complain about values with high bit set */
[...]
enum {
k16LE555PixelFormat = FOUR_CHAR_CODE('L555'), /* 16 bit LE rgb 555 (PC)*/
k16LE5551PixelFormat = FOUR_CHAR_CODE('5551'), /* 16 bit LE rgb 5551*/
k16BE565PixelFormat = FOUR_CHAR_CODE('B565'), /* 16 bit BE rgb 565*/
k16LE565PixelFormat = FOUR_CHAR_CODE('L565'), /* 16 bit LE rgb 565*/
k24BGRPixelFormat = FOUR_CHAR_CODE('24BG'), /* 24 bit bgr */
k32BGRAPixelFormat = FOUR_CHAR_CODE('BGRA'), /* 32 bit bgra (Matrox)*/
k32ABGRPixelFormat = FOUR_CHAR_CODE('ABGR'), /* 32 bit abgr */
k32RGBAPixelFormat = FOUR_CHAR_CODE('RGBA'), /* 32 bit rgba */
kYUVSPixelFormat = FOUR_CHAR_CODE('yuvs'), /* YUV 4:2:2 byte ordering 16-unsigned = 'YUY2'*/
kYUVUPixelFormat = FOUR_CHAR_CODE('yuvu'), /* YUV 4:2:2 byte ordering 16-signed*/
kYVU9PixelFormat = FOUR_CHAR_CODE('YVU9'), /* YVU9 Planar 9*/
kYUV411PixelFormat = FOUR_CHAR_CODE('Y411'), /* YUV 4:1:1 Interleaved 16*/
kYVYU422PixelFormat = FOUR_CHAR_CODE('YVYU'), /* YVYU 4:2:2 byte ordering 16*/
kUYVY422PixelFormat = FOUR_CHAR_CODE('UYVY'), /* UYVY 4:2:2 byte ordering 16*/
kYUV211PixelFormat = FOUR_CHAR_CODE('Y211'), /* YUV 2:1:1 Packed 8*/
k2vuyPixelFormat = FOUR_CHAR_CODE('2vuy') /* UYVY 4:2:2 byte ordering 16*/
};
Is the code that gives the warning (warning: multi-character character constant)
very crappy code :/
>
> --
> MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
> "The Universe doesn't give you any points for doing things that are easy."
> -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
More information about the MPlayer-dev-eng
mailing list