[MPlayer-dev-eng] [PATCH] Warning fixes

[Arpi]

Hi,

> > > Fix attached (fire-warningfix4.patch)
> > > I copy/pasted the way it is done in loader/dshow/libwin32.h
> > 
> > Have you tested it? I tried the same "fix" once and it caused SIGSEGV in qt
> > loader.
> Nope, but the warning disappeared. Don't commit that fix :)

probably byteorder problem. at least windows and quicktime fourcc's are in
different byteorder. (i have to bswap_32 everywhere to get them match)

> #define FOUR_CHAR_CODE(x)       ((unsigned long)(x)) /* otherwise compiler
> will complain about values with high bit set */
> [...]
> Is the code that gives the warning (warning: multi-character character
> constant)
yes we know it all. i suggest you a big RTFA, most of the topics in your
today mails were discussed already in the near past.

> very crappy code :/
yes. and it's coming as-is from the quicktime SDK. don't blame us, but Apple.

maybe someone with macos x should get the latest quicktime sdk, they
probably changed it to be more unix-friendly.
(the qt5 sdk i used supported only mac and windows C compilers & OS typedefs)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu