[MPlayer-dev-eng] [PATCH] mplayer fails to link with newer binutils

seru seru at gmx.net
Mon Dec 23 01:14:49 CET 2002


El lun, 23 de dic de 2002, a las 01:45:24 +0100, Arpi dijo:
> Hi,
> 
> > > > -static long decwin [544];
> > > > +real decwin [512+32];
> > > 
> > > Might seem a little ugly and stupid, but I did it for sake of consistency :)
> > > 'real' is a macro which is defined as 'float' in the whole mp3lib dir:
> > 
> > Arg, what an abomination. Whoever wrote that needs to look up the
> > meaning of real.
> 
> AFAIR one of the 2 mpg123 authors is the author of QPEG too, a very old DOS
> jpeg and other image viewer app written in borland pascal & asm.
> so he proabbly knows it well...
> btw it's OT. we should not change such things unless we have a good reason.
> cosmetics isn't good enough.
True, but if it causes a warning in older binutils and a fatal error (i suppose) in newer, we have a reason.
Let's first see if this patch solves the problem of the guy who started this thread.
> 
> 
> A'rpi / Astral & ESP-team
> 
> --
> Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng



More information about the MPlayer-dev-eng mailing list