[MPlayer-dev-eng] [PATCH] mplayer fails to link with newer binutils

[Soeren Sonnenburg]

On Mon, 2002-12-23 at 01:14, seru wrote:
> El lun, 23 de dic de 2002, a las 01:45:24 +0100, Arpi dijo:
> > Hi,
> > 
> > > > > -static long decwin [544];
> > > > > +real decwin [512+32];
> > > > 
> > > > Might seem a little ugly and stupid, but I did it for sake of consistency :)
> > > > 'real' is a macro which is defined as 'float' in the whole mp3lib dir:
> > > 
> > > Arg, what an abomination. Whoever wrote that needs to look up the
> > > meaning of real.
> > 
> > AFAIR one of the 2 mpg123 authors is the author of QPEG too, a very old DOS
> > jpeg and other image viewer app written in borland pascal & asm.
> > so he proabbly knows it well...
> > btw it's OT. we should not change such things unless we have a good reason.
> > cosmetics isn't good enough.
> True, but if it causes a warning in older binutils and a fatal error (i suppose) in newer, we have a reason.
> Let's first see if this patch solves the problem of the guy who started this thread.

No, doesn't help at all.

What about the patch I sent (unfortunately I sent it inline last
time...)

It just removes this #include "tabwin.c" .... and it works here on my
MMX machine... however I am not sure what happens on non MMX ones...

S.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: decwin_link.patch
Type: text/x-patch
Size: 403 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20021223/87cdae0f/attachment.bin>