[MPlayer-dev-eng] [PATCH] save/restore state for radeon_vid.c

[Svante Signell]

Alex,

Thanks for applying my changes. In an earlier vertion of the patch I
did save also the grapics/video color/masks but found that the only
register having any effect was OV0_KEY_CNTL. Anyway, it doesn't hurt
to save and restore all colorkey settings.

A question related to the radeon_vid and r128_vid drivers, contained
in the file radeon_vid.c. What do you think about splitting into two
files: r128_vid.c and radeon_vid.c. This would ease maintenance and
avoids use of #ifdefs.

Merry Christmas,
Svante


Alex Beregszaszi writes:
 > Hi,
 > 
 > > The latest patch for radeon_vid.c, v 1.54, makes the pink screen
 > > problem go away as well as to solve the shift problem. One item
 > > remains to solve, however. After exiting the vidix driver the card
 > > state is not restored correctly. This can easily be shown by trying
 > > the -vo xv or -vo sdl drivers (either as root or non-root) after
 > > running -vo xvidix (as root). The attached patch should work for all
 > > radeon/r128 cards, but has so far only been tested on a Radeon
 > > Mobility M6 LY.
 > Applied a patch based on yours (my saves the graphics color/mask and
 > video color/mask too)
 > 
 > Btw, i have done a patch like this about an half year ago, but with
 > some sync it went away.....
 > 
 > i hate that there are two different branches of vidix drivers...
 > 
 > -- 
 > Alex Beregszaszi  <alex at naxine.org>
 > (MPlayer Core Developer -- http://www.mplayerhq.hu/)
 > _______________________________________________
 > MPlayer-dev-eng mailing list
 > MPlayer-dev-eng at mplayerhq.hu
 > http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng