[MPlayer-dev-eng] [PATCH] save/restore state for radeon_vid.c

[Alex Beregszaszi]

Hi,

> Thanks for applying my changes. In an earlier vertion of the patch I
> did save also the grapics/video color/masks but found that the only
> register having any effect was OV0_KEY_CNTL. Anyway, it doesn't hurt
> to save and restore all colorkey settings.
yes, but it's more safer i think, if there's a brainded driver
that doesn't set back the colorkey color and masks.

btw, i'm thinking about a system that saves and later restores all the
registers that could hurt if they're changed.

> A question related to the radeon_vid and r128_vid drivers, contained
> in the file radeon_vid.c. What do you think about splitting into two
> files: r128_vid.c and radeon_vid.c. This would ease maintenance and
> avoids use of #ifdefs.
imho it's now clearer, becouse lot of staff is shared between rage128
and radeon drivers, and it's still not too big (50k) - the kerneldriver
was about 80k ;)

-- 
Alex Beregszaszi  <alex at naxine.org>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)