[MPlayer-dev-eng] [PATCH] vo_gl small change

Arpi arpi at thot.banki.hu
Sat Dec 28 14:29:00 CET 2002


Hi,

> +    if(slice_height != 0)
> +    {
imho no need for this if, just set slice_height==image_height to get
copy-all-in-one-pass mode what you want

> +      for(y0=0;y0<h-slice_height;y0+=slice_height){
> +        glTexSubImage2D( GL_TEXTURE_2D,  // target
>  		       0,              // level
>  		       x,              // x offset
> -		       y+i,            // y offset
> +		       y+y0,            // y offset
>  		       w,              // width
> -		       1,              // height
> +		       slice_height,              // height

needs to check if y+y0+slice_height<=h and use h-y+y0 otherwise.
(or it will copy more than it should)

(for the case when image_height%slice_height!=0)



A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list