[MPlayer-dev-eng] [PATCH] vo_gl small change
lumag at qnc.ru
lumag at qnc.ru
Sun Dec 29 14:42:44 CET 2002
Hello!
> > + if(slice_height != 0)
> > + {
> imho no need for this if, just set slice_height==image_height to get
> copy-all-in-one-pass mode what you want
If so, user must specify -vo gl:0 for each film, to set right
slice_height. Or I didn't understood?
>
> > + for(y0=0;y0<h-slice_height;y0+=slice_height){
> > + glTexSubImage2D( GL_TEXTURE_2D, // target
> > 0, // level
> > x, // x offset
> > - y+i, // y offset
> > + y+y0, // y offset
> > w, // width
> > - 1, // height
> > + slice_height, // height
>
> needs to check if y+y0+slice_height<=h and use h-y+y0 otherwise.
> (or it will copy more than it should)
{=cut from libvo/video_out.h=}
* w,h = width*height of area to be copied (in Y pixels)
* x,y = position at the destination image (in Y pixels)
{=end=}
So h is image_height, by meaning. And I check, that It doesn't send
extra lines, in exit-condition of loop (y0<h-slice_height).
>
> (for the case when image_height%slice_height!=0)
And for this case, there is extra glTexSubImage2D call after each loop.
{SNIP}
--
Dmitry.
More information about the MPlayer-dev-eng
mailing list