[MPlayer-dev-eng] [PATCH][RFC] transparent unpacking of .rar for transparent vobsub access

[D Richard Felker III]

On Fri, Jun 07, 2002 at 10:00:10AM +0200, pl wrote:
> Hi,
> 
> The attached patch allows reading vobsub "directly" from .rar.
> 
> Why?
> The win dll allows this so vobsub .sub often ship as .rar.

Then unrar them yourself and keep the unrar'd copy. Delete that rar
crap. :)

> It uses the 'rar' binary you've installed on your system to unpack the
> foo.sub of the foo.rar in /tmp, then opens /tmp/foo.sub and unlinks
> /tmp/foo.sub.

This is highly insecure and dangerous use of /tmp. At least have it
pipe output back into mplayer, or use ~/.mplayer/vobtmp or something.

> It's not clean (lots of debug output) and not ready for cvs inclusion
> right now (a generic perl/shell filter wrapping .sub in .rar/.zip/.gz
> etc would be much better IMO but I just wanted to make that work
> first...)
> 
> I'd just like to know whether some people might be interested in
> this feature and whether it's worth cleaning & committing.

If you really want this feature, you should find or write some rar
extracting code you can integrate directly, and make it optional at
compiletime. Calling external binaries like this is a total hack.
Also, keep in mind that this code should be GPL-compatible if you want
it included.

Rich