[MPlayer-dev-eng] mencoder.c (1.94) bug: "-lavcopts vbitrate=XXX"

Juan J. Sierralta P. juanjo at atmlab.utfsm.cl
Fri Mar 1 03:59:11 CET 2002


On Thu, 2002-02-28 at 23:43, Krister Lagerstrom wrote:
> Juan J. Sierralta P. wrote:
> 
> > 	Attached comes a patch that fix this problem.
> 
> 
> Looks good, except:
> 
> 
> > +    if (!lavc_param_vbitrate) /* != -1 */
> 
> 
> The comment is not correct anymore. It's a nitpick, I know, but bad 
> comments waste a lot of time for people who're trying to learn the code.

	It was a quick hack to solve the problem. And "cosmetic" patches aren
welcome here.
	BTW I been reporting that AVIs make by mencoder aren't playable on
Windows Media Player v7.1, have you had the same problem ?

-- 
Juanjo sin .sig :(




More information about the MPlayer-dev-eng mailing list