[MPlayer-dev-eng] mencoder.c (1.94) bug: "-lavcopts vbitrate=XXX"

[D Richard Felker III]

On Thu, Feb 28, 2002 at 11:59:11PM -0300, Juan J. Sierralta P. wrote:
> On Thu, 2002-02-28 at 23:43, Krister Lagerstrom wrote:
> > Juan J. Sierralta P. wrote:
> > 
> > > 	Attached comes a patch that fix this problem.
> > 
> > 
> > Looks good, except:
> > 
> > 
> > > +    if (!lavc_param_vbitrate) /* != -1 */
> > 
> > 
> > The comment is not correct anymore. It's a nitpick, I know, but bad 
> > comments waste a lot of time for people who're trying to learn the code.
> 
> 	It was a quick hack to solve the problem. And "cosmetic" patches aren
> welcome here.
> 	BTW I been reporting that AVIs make by mencoder aren't playable on
> Windows Media Player v7.1, have you had the same problem ?

I've never had the problem...I don't exactly have WMP to test, but
I've sent files I encoded to Windows users with no trouble...

Rich