[MPlayer-dev-eng] [PATCH] rff - demux_control patch v1.2

Balatoni Denes pnis at coder.hu
Sun Nov 10 22:47:52 CET 2002


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi!


> > > > -  sh_video->i_bps=((float)sh_video->i_bps/(float)sh_video->v
> > > > ideo.dwLength)*sh_video->fps;
> > > > +  sh_video->i_bps=((float)sh_video->i_bps/(float)priv->numbe
> > > > rofframes)*sh_video->fps;
> > >
> > > why?
> left it as-is, or explain why does this change needed.
> i really hate changes without any reason.
> i'm not against fixing bugs, if you can prove/explain it's a bug.
Ok my last explanation didn't make much sense, I agree:) 
So here you are trying to divide i_bps with the frame number, no ?
And frame number is already calculated, even when dwLength is something
stupid (for which you don't check here anywayí :) (ok I don't know if
dwLength could be 0 or not)).
So that was my reason.


Denes

- -- 
"Use the source Luke !"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9ztQIaQToeq3jgogRAhQQAJ0fTJ1SN76cwPLtMzTFTNEzKS4FRwCgg5WB
az3wy8lxhYGd2WCQnwGEW7Q=
=+G8F
-----END PGP SIGNATURE-----



More information about the MPlayer-dev-eng mailing list