[MPlayer-dev-eng] [PATCH] rff - demux_control patch v1.2

[Arpi]

Hi,

> > > > > ideo.dwLength)*sh_video->fps;
> > > > > +  sh_video->i_bps=((float)sh_video->i_bps/(float)priv->numbe
> > > > > rofframes)*sh_video->fps;
> > > >
> > > > why?
> > left it as-is, or explain why does this change needed.
> > i really hate changes without any reason.
> > i'm not against fixing bugs, if you can prove/explain it's a bug.
> Ok my last explanation didn't make much sense, I agree:) 
> So here you are trying to divide i_bps with the frame number, no ?
> And frame number is already calculated, even when dwLength is something
> stupid (for which you don't check here anywayí :) (ok I don't know if
> dwLength could be 0 or not)).
> So that was my reason.
so it's pure cosmetics.

anyway afair i_bps is only used for mpeg seeking, nothing else, so actually
this whole code is useless :)

again. don't change things with reason 'i think' or 'xine does this' or
'this looks better'.
especially not in code that is really hard to test (i plan to create a
regression test sample set for demuxer layer - but for now the only way to
test is playing hundreds of samples and waiting for user bugreports).

the topic was adding a control() function to query position & length,
nothing about cosmetics and porting probably bad code from xine...

do it in a separate patch, with some good enough reasons and samples.
then we'll consider accepting it.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu