[MPlayer-dev-eng] [PATCH] rff - demux_control patch v1.2

[Balatoni Denes]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi!

> > Ok my last explanation didn't make much sense, I agree:)
> > So here you are trying to divide i_bps with the frame number, no ?
> > And frame number is already calculated, even when dwLength is something
> > stupid (for which you don't check here anywayí :) (ok I don't know if
> > dwLength could be 0 or not)).
> > So that was my reason.
>
> so it's pure cosmetics.

Man, a few mails ago you were telling me the importance of returning 
demux_ctrl_inaccurate. This part could actually cause a divide by zero.
It's your business, but maybe you could try not contradicting yourself for 
two minutes. 

> again. don't change things with reason 'i think' or 'xine does this' or
> 'this looks better'.
I changed that second back. Next time I will always say I know for sure, ok 
?;)


> the topic was adding a control() function to query position & length,
> nothing about cosmetics and porting probably bad code from xine...

> do it in a separate patch, with some good enough reasons and samples.
> then we'll consider accepting it.
Well, I don't think I would like to explain all my patches 3 times, before 
they are rejected.

I attached a patch, maybe you can print it on a soft paper and wipe your ....
with it, or something;)

bye
Denes


- -- 
"Use the source Luke !"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9ztp9aQToeq3jgogRAu/MAKCDfEgEkMmUI7164WUO2jLIPxS4CACfSdIN
uMmMR00IkVwdVCH9tT0b+Cw=
=N6Vt
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demux-control-patch3
Type: text/x-c++
Size: 10605 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20021110/8a86e7dd/attachment.bin>