[MPlayer-dev-eng] [PATCH] Menu optimization

Arpi arpi at thot.banki.hu
Mon Nov 18 16:57:27 CET 2002


Hi,

> > Dunno, most changes look like cosmetics ;). I take a better look at it
> > tonight.
> 
> Yes, because I added an if {} else {} block so I moved your code two
> spaces to the right :)

there is a paragraph about this in cvs-howto.txt

> basicaly that's
> if(showing) {
>   do menu displaying stuff and copy to dpmi
>   return vf_next_put_image using the new dpmi
> } else {
>   return vf_next_put_image, using original mpi
THIS IS *BAD* !

you NEVER EVER should put_image(original mpi)
read docs/tech/libmpcodecs.txt vfilter section

get a new mpi with TYPE==EXPORT and copy the pointers
maybe i'll add a common function for this.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list