[MPlayer-dev-eng] [PATCH] Menu optimization
Colin Leroy
colin at colino.net
Mon Nov 18 16:59:17 CET 2002
On Mon, 18 Nov 2002 16:57:27 +0100 Arpi <arpi at thot.banki.hu> wrote:
Hi Arpi,
> > Yes, because I added an if {} else {} block so I moved your code two
> > spaces to the right :)
>
> there is a paragraph about this in cvs-howto.txt
I know it, but if I put existing code in a new if{} block, shouldn't i
reindent (using original indenting style) the existing to be ok in the if
block ?
ie
- a
- if(c)
- d
+ if(b) {
+ a
+ if(c)
+ d
+ }
?
> > basicaly that's
> > if(showing) {
> > do menu displaying stuff and copy to dpmi
> > return vf_next_put_image using the new dpmi
> > } else {
> > return vf_next_put_image, using original mpi
> THIS IS *BAD* !
>
> you NEVER EVER should put_image(original mpi)
> read docs/tech/libmpcodecs.txt vfilter section
> get a new mpi with TYPE==EXPORT and copy the pointers
> maybe i'll add a common function for this.
Thanks for the tip, i'll send an updated patch.
--
Colin
"Bus error (Passengers dumped)."
More information about the MPlayer-dev-eng
mailing list