[MPlayer-dev-eng] [PATCH] [REPOST] Ericsson phone remote control

[D Richard Felker III]

On Wed, Oct 16, 2002 at 12:26:38AM +0000, John Being wrote:
> >> Probably :), but no uglier that LIRC code that I based on, and which is
> >> included
> >> into main distribution. Anyway it's up to you, I'm not crazy for my 
> >patches
> >> being applied ;).
> >
> >Imho it's ok to include such feature/patch into mplayer, this is the 
> >purpose
> >if the input layer. But i don't (really don't) like the fork() in the 
> >middle
> >of your code. MPlayer is a single thread application and forking for input
> >handler is nonsense, especially by looking at your child process, it can be
> >done simply without any fork, imho.
> >So, the patch in this form is refused.
> OK, but LIRC code behaves exactly like this. I'm myself hate those fork(), 
> but though it's
> MPlayer'ism to write in such a way :). Would you be happier with another 
> thread, or with select() based approach?
> I could do both, whatever is more relevant.

Use select, of course. Definitely NOT threads.

Rich