[MPlayer-dev-eng] [PATCH] [REPOST] Ericsson phone remote control

[Arpi]

Hi,

> >of your code. MPlayer is a single thread application and forking for input
> >handler is nonsense, especially by looking at your child process, it can be
> >done simply without any fork, imho.
> >So, the patch in this form is refused.
> OK, but LIRC code behaves exactly like this. I'm myself hate those fork(), 
> but though it's
> MPlayer'ism to write in such a way :). Would you be happier with another 
> thread, or with select() based approach?
> I could do both, whatever is more relevant.

select() is ok. threads/fork is not.

anyway you're right, lirc.c has this fork() too, i never check that cide
(was not commited by me) but it's also nonsense, the old (recently removed)
input code also handle lirc without any fork.

someone should fix lirc.c too.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu