[MPlayer-dev-eng] [PATCH] a couple cygwin patches for configure

[D Richard Felker III]

On Sat, Sep 07, 2002 at 02:43:56PM +0200, Felix Buenemann wrote:
> On Friday 30 August 2002 23:15, Sycotic Smith wrote:
> > 3) fixes SDL_LIB and SDL_INC in config.mak
> >   Let me know if I need to do this differently, I'm not completely sure
> > this is correct...
> IMHO it's better to grep the needed stuff from sdl-config output and throw 
> away the rest if on cygwin.

IMHO it is best to tell the user to fix their sdl-config script if
installing on cygwin. The script that comes with SDL is written for
mingw and will break ALL cygwin programs, not just mplayer. Simply
editing out the stupid "no default includes" and "no cygwin" junk will
fix the problem permenantly, for any program you want to compile in
cygwin. Seems like a much cleaner solution to me...

> > 4) fixes AA_LIB in config.mak if X11 is found.
> please fix cygwin && _x11=yes it should use && test $_x11 = "yes" to be 
> portable.

No, it should be "$_x11" = yes you mean. Quotes around yes are
optional since it contains no metachars, but around $_x11 are
mandatory in case it somehow happens to be empty.

Rich