[MPlayer-dev-eng] [patch] improved searching for subtitles

[Arpi]

Hi,

> this patch replaces subreader.c:sub_filename with another version, which 
> reads the movie and subtitle directories via opendir & readdir instead 
> of blindly trying to open various files. The filenames are trimmed so 
> it's capable of finding filenames which differ in character case or 
> whitespace characters. It also adds a -subid option which specifies the 
> string required after the movie name (eg. like Face.Off_CZ.srt) to 
> prefer a specific subtitle language by default.
> 
> Is it post-0.90 or ok to commit now?

I vote for post-0.90 because
- patch is long, replaces tested working code with new longer untested one
- it's a new feature not a trivial/critical bugfix
- it adds new option, which should be documented, translated etc
- i don't think this feature is useful at all.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino