[MPlayer-dev-eng] [PATCH] demux_real.c : make the mess even

[Balatoni Denes]

Hi!

> > if(!(s[0]&0x8) || !(s[0]&0x10)){ // P || I  frame -> swap timestamps
>
> it ha snothing with audio or sth you wrote. it's for simple I/P vs B frame
> reordering. (I/P frames are coded before the B frame sbut displayed after,
> so we have to swap their timestamps)
yes, but I explained what I meant in my first email 
try it with the stream.dump2.rm if it's still on ftp.mphq

> > according to the fine documentation if num of packets
> > is reached, a new data chunk could be coming (with the
> > chunk header etc., xine checks for this)
>
> nice. then fix that bug, i don't remember seeing anything like that in your
> "patch"
correct it is not in there


> > > so if you have real fixes, not hacks and not 'i uncomment this part of
> > > code because i think it's a cool thing' then send an usable patch.
> >
> > sure
> > i don't think it is cool
> > sorry for sending a patch that fixes something that
> > works in xine, but not in mplayer
> > my bad
>
> not it doesn't fix but probably breaks many things.
> mayeb it fixes one or a few streams.
> and i don't care if it works in xine or not, xine is a bug buggy hack.
> they steal our demuxer and trying to hack it without understanding how it
> works.
I guess they unerstood somewhat
I downloaded a few rms as I was curious to see it break
they worked for me
if you can give me a sample where it breaks that would help

> > before telling me these very usefull thoughts, did you actually look at
> > demux_real? it is one big hack, nobody knows why stuff is there (as it is
>
> wrong. for example i know.
I am sure you do. So what is bit 5 in vpkg_header than?

> > not documented by realnetworks of course), full of gotos and printfs
>
> ah you're anti-goto coder...
no I don't care, it makes things shorter and sometimes better of course
I was just talking about the fact there are many ugly things in the code
my patch does not make it nicer, but fixes the problems I noticed
of course I am open to any constructive suggestions
flame I am not open to - but of course I enjoy takeing part in it, for some 
time at least

> > so I really don't get what you are talking about
>
> i'm talking about code ferezee and a messy ugly shit you sent named
> 'patch'. and you expect it to be commited? lol.
no, I thought it would be welcome, as it fixed things for me that
were obviously broken before. If you think it wouldmake demux_real
more broken and not less, that is fine, tell me what do you think is the 
problem and I will see what I can do
formating the code to your taste is not something I am good at I admit,

> > and it is not fun resending every patch 5 times, just because one deleted
>
> easy: then send usable patch at first time...
as you can see it is not that easy

> i didn't aks you to fix it. you wanted to fix but failed, your 'patch' is
> everything but a patch.
i did not fail, as it fixed the problem for me.
"well if you don't like it, it suits us just fine" (you know state of mind by 
bomb :) )

bye
Denes