[MPlayer-dev-eng] [PATCH] demux_real.c : make the mess even

[Arpi]

Hi,

> > wrong. for example i know.
> I am sure you do. So what is bit 5 in vpkg_header than?

hmm?

6 LSB of vpkg_header contains the number of sub-packets divided by 2.
the 2 MSB controls the subpacket fragmentation.

> > > not documented by realnetworks of course), full of gotos and printfs
> >
> > ah you're anti-goto coder...
> no I don't care, it makes things shorter and sometimes better of course
> I was just talking about the fact there are many ugly things in the code
> my patch does not make it nicer, but fixes the problems I noticed
> of course I am open to any constructive suggestions

i'm open to constructive fixes, not for hacks.

> were obviously broken before. If you think it wouldmake demux_real
> more broken and not less, that is fine, tell me what do you think is the 
> problem and I will see what I can do

i already told you: it removes the timestamp calculation so it will break
all non-constant fps streams. try the lotr trailers for example.
but any RV30/RV40 samples should be enough.

> formating the code to your taste is not something I am good at I admit,
you should not format at all.

> > easy: then send usable patch at first time...
> as you can see it is not that easy
akkor meg ne sopankodj

> > i didn't aks you to fix it. you wanted to fix but failed, your 'patch' is
> > everything but a patch.
> i did not fail, as it fixed the problem for me.
then be happy with it applied on your local tree.
i'm waiting for correct fix.
i'm open for the fact that my timestamp calc hack is wrong, if you replace
it by a better one. just removing it isn't ok. it was added by reason.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino